Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of Feb Heartbeat #2190

Merged
merged 22 commits into from
Feb 18, 2021
Merged

Draft of Feb Heartbeat #2190

merged 22 commits into from
Feb 18, 2021

Conversation

jendefig
Copy link
Contributor

Here's draft of Feb Heartbeat. Need @elleobrien and anyone else to check it out!

@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 12, 2021 16:14 Inactive
@elleobrien
Copy link
Contributor

@jendefig good stuff! i put some suggestions in. @shcheklein is also a regular HB reviewer so I tagged him in too to have a look. my big feedback:

  • when we mention people by name, it's great to link to their social accounts
  • we have an external-link element (you can see it in the last HB) for creating big buttons with images that link to outside content. It can be effective for highlighting some of our favorite content, so it's worth considering if you want to use that in this HB.
  • I like your gifs and you're writing style! The energy is fun and welcoming.

@jendefig
Copy link
Contributor Author

@elleobrien Ok. Cool. I will figure out the links for the peeps I missed and I see the external viewer now. I'll add that for the DAGsHub one. Couple questions. Will this article be from you or me? And at the top: How is the CommentsURL generated? (the last 3 digits? And to make these changes, I just do so locally; add, commit and push to the branch, correct?

@jendefig
Copy link
Contributor Author

Also - How/Where are the heading pics done? Are there .svgs in there that I can switch out for the month? Should I also correct the January one that says December Heartbeat? I noticed they are also getting cut in the blog page. So I guess this is a social sharing image formatted to Twitter size and it's being cropped to square on the blog page? There should be two different images.

Copy link
Contributor

@elleobrien elleobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@will this article be from you or me?

This will be from you!

How is the CommentsURL generated?

We make a new topic here and then link to it. Ping dmitry or ivan if you need admin access to our Discuss forum!

And to make these changes, I just do so locally; add, commit and push to the branch, correct?

yep!

content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
@elleobrien
Copy link
Contributor

Also - How/Where are the heading pics done? Are there .svgs in there that I can switch out for the month?

I make them each month in Adobe Spark. If you want to use Spark I'm happy to share the project with you, otherwise you can make one in whatever tool you'd like. Or we could put a request on Upwork for an artist to make one.

Should I also correct the January one that says December Heartbeat?

I don't think so, but I'm not positive what you're referring to. Can you clarify?

I noticed they are also getting cut in the blog page. So I guess this is a social sharing image formatted to Twitter size and it's being cropped to square on the blog page? There should be two different images.

The website does some automatic cropping for displays, but it's just one image. I just make sure it's an image that doesn't get cutoff badly in the Blog page view (it's not usually a problem since all the interesting bits are close to the center)

@will
Copy link

will commented Feb 12, 2021

@will this article be from you or me?

This will be from you!

Sorry, it'd take me forever just to get up to speed, plus i have a job already so sorry I don’t think I can help here :(

@elleobrien
Copy link
Contributor

@will this article be from you or me?

This will be from you!

Sorry, it'd take me forever just to get up to speed, plus i have a job already so sorry I don’t think I can help here :(

@will so sorry I accidentally tagged you here :) sorry if there was any scare, we are certainly not expecting a blog from you!

@jendefig
Copy link
Contributor Author

Also - How/Where are the heading pics done? Are there .svgs in there that I can switch out for the month?

I make them each month in Adobe Spark. If you want to use Spark I'm happy to share the project with you, otherwise you can make one in whatever tool you'd like. Or we could put a request on Upwork for an artist to make one.

Should I also correct the January one that says December Heartbeat?

I don't think so, but I'm not positive what you're referring to. Can you clarify?

I noticed they are also getting cut in the blog page. So I guess this is a social sharing image formatted to Twitter size and it's being cropped to square on the blog page? There should be two different images.

The website does some automatic cropping for displays, but it's just one image. I just make sure it's an image that doesn't get cutoff badly in the Blog page view (it's not usually a problem since all the interesting bits are close to the center)
image

@jendefig
Copy link
Contributor Author

jendefig commented Feb 13, 2021

I can use inkscape or Over to make the graphic. But where are they stored.

I make them each month in Adobe Spark. If you want to use Spark I'm happy to share the project with you, otherwise you can make one in whatever tool you'd like. Or we could put a request on Upwork for an artist to make one.

@elleobrien Spark pages? I'm there an spark post as [email protected]. I could do on another, but I want to make sure I get the font right and size.

Everything else has been corrected plus a couple other typos I found, except

  1. The Header photo, which I can do when you send the file.
  2. the commentsURL: I need admin access but I am signed up in there. @shcheklein

@elleobrien
Copy link
Contributor

@elleobrien Spark pages? I'm there as [email protected]. I could do on another, but I want to make sure I get the font right.

I just sent you an invite to the Spark template over gmail!

@shcheklein shcheklein had a problem deploying to dvc-landing-febheartbea-ndkuhw February 16, 2021 21:14 Failure
@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 16, 2021 23:00 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 16, 2021 23:09 Inactive
@elleobrien
Copy link
Contributor

@jendefig last suggested edits:

  1. I think there's a typo in the description: "read" should be capitalized in "read all about our growing team" in both the short and long description.
  2. the spacy pic on the external-link card displays a little funny. could we just show their logo there instead of what we have now (spacy_integration.png)?

@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 17, 2021 00:01 Inactive
Copy link
Contributor Author

@jendefig jendefig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I've adjusted typo, dates, images, removed duplicate and treated the Dagshub article like I treated the spacy article.

content/blog/2021-02-12-february-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 17, 2021 21:08 Inactive
@jendefig
Copy link
Contributor Author

@shcheklein This seems to be working. But it
still balking at some links?

@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 17, 2021 22:29 Inactive
@jendefig
Copy link
Contributor Author

@shcheklein It's done. It's just the links.

@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 18, 2021 00:16 Inactive
@jendefig jendefig requested a review from shcheklein February 18, 2021 00:31
@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 18, 2021 01:07 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 18, 2021 01:34 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 18, 2021 01:35 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 18, 2021 01:36 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-febheartbea-ndkuhw February 18, 2021 02:07 Inactive
@shcheklein shcheklein merged commit ba8178e into master Feb 18, 2021
@shcheklein shcheklein deleted the febheartbeat branch February 18, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants